Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak comments and variable names for stylistic consistency #66

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Tweak comments and variable names for stylistic consistency #66

merged 2 commits into from
Jul 30, 2021

Conversation

tinker-michaelj
Copy link
Contributor

n/m

tinker-michaelj added 2 commits July 30, 2021 11:44
ljianghedera
ljianghedera approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@ljianghedera ljianghedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tinker-michaelj tinker-michaelj merged commit 8c9b26b into 064-D-freeze-txn-use-instant Jul 30, 2021
@tinker-michaelj tinker-michaelj deleted the style-changes branch July 30, 2021 17:35
tinker-michaelj pushed a commit that referenced this pull request Aug 6, 2021
@ljianghedera
064 d freeze txn use instant (#67)
384383f 
* Added start, end timestamp and deprecate start and end hours/mins

Signed-off-by: ljianghedera <[email protected]>

* Add freeze start timestamp and deprecate start/end hour/min.

Signed-off-by: ljianghedera <[email protected]>

* Tweak comments and variable names for stylistic consistency (#66)

* Tweak comments and variable names for stylistic consistency

Signed-off-by: tinker-michaelj <[email protected]>

* Backwards compatibility

Signed-off-by: tinker-michaelj <[email protected]>

Co-authored-by: Michael Tinker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljianghedera ljianghedera ljianghedera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tinker-michaelj @ljianghedera